spantaleev/matrix-docker-ansible-deploy
1
0
Fork 0
mirror of https://github.com/spantaleev/matrix-docker-ansible-deploy.git synced 2026-08-06 16:03:06 +10:00
Code Issues Packages Projects Releases Wiki Activity

Fix "'list object' has no attribute 'keys'" in deprecation checks

Browse Source 
The variables holding matched deprecated variable names used to be
dictionaries (built via `vars | dict2items | ... | items2dict`), so
calling `.keys()` on them was correct.

Since a1f6ee4dc9, they are lists produced
by the `ansible.builtin.varnames` lookup, but 15 of the messages
consuming them were left calling `.keys()`.

The failing tasks are gated behind a `| length > 0` condition, so only
people who actually still carry one of these deprecated variables would
hit this. Such people were greeted by a cryptic templating error instead
of the message telling them what to rename or remove.

Fixes https://github.com/spantaleev/matrix-docker-ansible-deploy/issues/5491

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Slavi Pantaleev
2026-08-04 17:14:01 +03:00
parent bd2b13979a
commit bd8a79c974
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
roles/custom/matrix_playbook_migration/tasks/validate_config.yml
+15 -15
View File
@@ -188,7 +188,7 @@
After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so. After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so.
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_matrix_prometheus_postgres_exporter_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_matrix_prometheus_postgres_exporter_migration_vars | join(', ') }}
when: "matrix_playbook_migration_matrix_prometheus_postgres_exporter_migration_vars | length > 0" when: "matrix_playbook_migration_matrix_prometheus_postgres_exporter_migration_vars | length > 0"
- when: matrix_playbook_migration_matrix_backup_borg_migration_validation_enabled | bool - when: matrix_playbook_migration_matrix_backup_borg_migration_validation_enabled | bool
@@ -207,7 +207,7 @@
After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so. After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so.
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_backup_borg_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_backup_borg_migration_vars | join(', ') }}
when: "matrix_playbook_migration_backup_borg_migration_vars | length > 0" when: "matrix_playbook_migration_backup_borg_migration_vars | length > 0"
- when: matrix_playbook_migration_matrix_grafana_migration_validation_enabled | bool - when: matrix_playbook_migration_matrix_grafana_migration_validation_enabled | bool
@@ -226,7 +226,7 @@
After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so. After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so.
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_grafana_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_grafana_migration_vars | join(', ') }}
when: "matrix_playbook_migration_grafana_migration_vars | length > 0" when: "matrix_playbook_migration_grafana_migration_vars | length > 0"
- when: matrix_playbook_migration_matrix_ntfy_migration_validation_enabled | bool - when: matrix_playbook_migration_matrix_ntfy_migration_validation_enabled | bool
@@ -245,7 +245,7 @@
After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so. After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so.
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_ntfy_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_ntfy_migration_vars | join(', ') }}
when: "matrix_playbook_migration_ntfy_migration_vars | length > 0" when: "matrix_playbook_migration_ntfy_migration_vars | length > 0"
- when: matrix_playbook_migration_matrix_redis_migration_validation_enabled | bool - when: matrix_playbook_migration_matrix_redis_migration_validation_enabled | bool
@@ -264,7 +264,7 @@
After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so. After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so.
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_redis_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_redis_migration_vars | join(', ') }}
when: "matrix_playbook_migration_redis_migration_vars | length > 0" when: "matrix_playbook_migration_redis_migration_vars | length > 0"
- when: matrix_playbook_migration_redis_valkey_migration_validation_enabled | bool - when: matrix_playbook_migration_redis_valkey_migration_validation_enabled | bool
@@ -282,7 +282,7 @@
After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so. After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so.
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_redis_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_redis_migration_vars | join(', ') }}
when: "matrix_playbook_migration_redis_migration_vars | length > 0" when: "matrix_playbook_migration_redis_migration_vars | length > 0"
- when: matrix_playbook_migration_keydb_valkey_migration_validation_enabled | bool - when: matrix_playbook_migration_keydb_valkey_migration_validation_enabled | bool
@@ -300,7 +300,7 @@
After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so. After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so.
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_keydb_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_keydb_migration_vars | join(', ') }}
when: "matrix_playbook_migration_keydb_migration_vars | length > 0" when: "matrix_playbook_migration_keydb_migration_vars | length > 0"
- when: matrix_playbook_migration_matrix_etherpad_migration_validation_enabled | bool - when: matrix_playbook_migration_matrix_etherpad_migration_validation_enabled | bool
@@ -319,7 +319,7 @@
After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so. After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so.
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_etherpad_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_etherpad_migration_vars | join(', ') }}
when: "matrix_playbook_migration_etherpad_migration_vars | length > 0" when: "matrix_playbook_migration_etherpad_migration_vars | length > 0"
- when: matrix_playbook_migration_matrix_aux_migration_validation_enabled | bool - when: matrix_playbook_migration_matrix_aux_migration_validation_enabled | bool
@@ -338,7 +338,7 @@
After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so. After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so.
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_aux_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_aux_migration_vars | join(', ') }}
when: "matrix_playbook_migration_aux_migration_vars | length > 0" when: "matrix_playbook_migration_aux_migration_vars | length > 0"
- when: matrix_playbook_migration_matrix_jitsi_migration_validation_enabled | bool - when: matrix_playbook_migration_matrix_jitsi_migration_validation_enabled | bool
@@ -357,7 +357,7 @@
After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so. After renaming them, please do not forget to fetch the Ansible role. See docs/maintenance-upgrading-services.md for details about how to do so.
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_jitsi_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_jitsi_migration_vars | join(', ') }}
when: "matrix_playbook_migration_jitsi_migration_vars | length > 0" when: "matrix_playbook_migration_jitsi_migration_vars | length > 0"
- when: matrix_playbook_migration_matrix_bridge_postmoogle_migration_validation_enabled | bool - when: matrix_playbook_migration_matrix_bridge_postmoogle_migration_validation_enabled | bool
@@ -373,7 +373,7 @@
Please rename all variables (`matrix_bot_postmoogle_` -> `matrix_bridge_postmoogle_`) on your configuration file (vars.yml). Please rename all variables (`matrix_bot_postmoogle_` -> `matrix_bridge_postmoogle_`) on your configuration file (vars.yml).
The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_postmoogle_migration_vars.keys() | join(', ') }} The following variables in your configuration need to be renamed: {{ matrix_playbook_migration_postmoogle_migration_vars | join(', ') }}
when: "matrix_playbook_migration_postmoogle_migration_vars | length > 0" when: "matrix_playbook_migration_postmoogle_migration_vars | length > 0"
- when: matrix_playbook_migration_matrix_nginx_proxy_elimination_variable_transition_checks_enabled | bool - when: matrix_playbook_migration_matrix_nginx_proxy_elimination_variable_transition_checks_enabled | bool
@@ -479,7 +479,7 @@
You should remove all its variables (`matrix_nginx_proxy_*`) from your configuration file (vars.yml). You should remove all its variables (`matrix_nginx_proxy_*`) from your configuration file (vars.yml).
The following variables in your configuration should be renamed: {{ matrix_playbook_migration_nginx_proxy_migration_vars.keys() | join(', ') }} The following variables in your configuration should be renamed: {{ matrix_playbook_migration_nginx_proxy_migration_vars | join(', ') }}
when: "matrix_playbook_migration_nginx_proxy_migration_vars | length > 0" when: "matrix_playbook_migration_nginx_proxy_migration_vars | length > 0"
- when: matrix_playbook_migration_matrix_ssl_leftover_variable_checks_enabled | bool - when: matrix_playbook_migration_matrix_ssl_leftover_variable_checks_enabled | bool
@@ -495,7 +495,7 @@
You should remove all its variables (`matrix_ssl_*`) from your configuration file (vars.yml). You should remove all its variables (`matrix_ssl_*`) from your configuration file (vars.yml).
The following variables in your configuration should be renamed: {{ matrix_playbook_migration_ssl_migration_vars.keys() | join(', ') }} The following variables in your configuration should be renamed: {{ matrix_playbook_migration_ssl_migration_vars | join(', ') }}
when: "matrix_playbook_migration_ssl_migration_vars | length > 0" when: "matrix_playbook_migration_ssl_migration_vars | length > 0"
- block: - block:
@@ -506,7 +506,7 @@
- name: (Deprecation) Catch and report matrix_ssl variables - name: (Deprecation) Catch and report matrix_ssl variables
ansible.builtin.fail: ansible.builtin.fail:
msg: >- msg: >-
We found usage of the following variables which are now removed: {{ matrix_playbook_migration_matrix_synapse_container_labels_public_client_synapse_oidc_vars.keys() | join(', ') }} We found usage of the following variables which are now removed: {{ matrix_playbook_migration_matrix_synapse_container_labels_public_client_synapse_oidc_vars | join(', ') }}
when: "matrix_playbook_migration_matrix_synapse_container_labels_public_client_synapse_oidc_vars | length > 0" when: "matrix_playbook_migration_matrix_synapse_container_labels_public_client_synapse_oidc_vars | length > 0"
- block: - block:
@@ -517,7 +517,7 @@
- name: (Deprecation) Catch and report matrix_ssl variables - name: (Deprecation) Catch and report matrix_ssl variables
ansible.builtin.fail: ansible.builtin.fail:
msg: >- msg: >-
We found usage of the following variables which are now removed: {{ matrix_playbook_migration_matrix_synapse_reverse_proxy_companion_container_labels_public_client_synapse_oidc_vars.keys() | join(', ') }} We found usage of the following variables which are now removed: {{ matrix_playbook_migration_matrix_synapse_reverse_proxy_companion_container_labels_public_client_synapse_oidc_vars | join(', ') }}
when: "matrix_playbook_migration_matrix_synapse_reverse_proxy_companion_container_labels_public_client_synapse_oidc_vars | length > 0" when: "matrix_playbook_migration_matrix_synapse_reverse_proxy_companion_container_labels_public_client_synapse_oidc_vars | length > 0"
- name: (Deprecation) Catch and report devture_postgres_backup variables - name: (Deprecation) Catch and report devture_postgres_backup variables