Fix repeater battery % inconsistency and add configurable repeater battery chemistry (#199)

* fix(repeater): unify battery percentage math and add repeater chemistry setting

- Add shared battery percent utility used by connector, repeater status, and telemetry

- Add repeater-specific battery chemistry persistence and service accessors

- Add repeater chemistry selector in Repeater Hub

- Ensure telemetry and status compute percentages consistently from same chemistry

- Add focused battery utility tests

Refs #116

Refs #174

* fix: Flutter Analyzer Errors fixed Recent Merge Compatible

* Unify repeater battery source across status and telemetry

lib/screens/repeater_hub_screen.dart

@@ -1,7 +1,9 @@
 import 'package:flutter/material.dart';
 import 'package:meshcore_open/connector/meshcore_protocol.dart';
+import 'package:provider/provider.dart';
 import '../l10n/l10n.dart';
 import '../models/contact.dart';
+import '../services/app_settings_service.dart';
 import 'repeater_status_screen.dart';
 import 'repeater_cli_screen.dart';
 import 'repeater_settings_screen.dart';
@@ -21,6 +23,10 @@ class RepeaterHubScreen extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     final l10n = context.l10n;
+    final settingsService = context.watch<AppSettingsService>();
+    final chemistry = settingsService.batteryChemistryForRepeater(
+      repeater.publicKeyHex,
+    );
     return Scaffold(
       appBar: AppBar(
         title: Column(
@@ -107,6 +113,62 @@ class RepeaterHubScreen extends StatelessWidget {
               ),
             ),
             const SizedBox(height: 24),
+            Card(
+              child: Padding(
+                padding: const EdgeInsets.fromLTRB(16, 16, 16, 12),
+                child: Column(
+                  crossAxisAlignment: CrossAxisAlignment.start,
+                  children: [
+                    Row(
+                      children: [
+                        const Icon(Icons.battery_full),
+                        const SizedBox(width: 10),
+                        Expanded(
+                          child: Text(
+                            l10n.appSettings_batteryChemistry,
+                            style: const TextStyle(
+                              fontSize: 16,
+                              fontWeight: FontWeight.w600,
+                            ),
+                          ),
+                        ),
+                      ],
+                    ),
+                    const SizedBox(height: 12),
+                    DropdownButtonFormField<String>(
+                      initialValue: chemistry,
+                      isExpanded: true,
+                      decoration: const InputDecoration(
+                        border: UnderlineInputBorder(),
+                        isDense: true,
+                      ),
+                      onChanged: (value) {
+                        if (value == null) return;
+                        settingsService.setBatteryChemistryForRepeater(
+                          repeater.publicKeyHex,
+                          value,
+                        );
+                      },
+                      items: [
+                        DropdownMenuItem(
+                          value: 'nmc',
+                          child: Text(l10n.appSettings_batteryNmc),
+                        ),
+                        DropdownMenuItem(
+                          value: 'lifepo4',
+                          child: Text(l10n.appSettings_batteryLifepo4),
+                        ),
+                        DropdownMenuItem(
+                          value: 'lipo',
+                          child: Text(l10n.appSettings_batteryLipo),
+                        ),
+                      ],
+                    ),
+                  ],
+                ),
+              ),
+            ),
+            const SizedBox(height: 24),
             Text(
               l10n.repeater_managementTools,
               style: const TextStyle(fontSize: 18, fontWeight: FontWeight.bold),

lib/screens/repeater_status_screen.dart

@@ -8,7 +8,9 @@ import '../models/contact.dart';
 import '../models/path_selection.dart';
 import '../connector/meshcore_connector.dart';
 import '../connector/meshcore_protocol.dart';
+import '../services/app_settings_service.dart';
 import '../services/repeater_command_service.dart';
+import '../utils/battery_utils.dart';
 import '../widgets/path_management_dialog.dart';
 
 class RepeaterStatusScreen extends StatefulWidget {
@@ -179,6 +181,12 @@ class _RepeaterStatusScreenState extends State<RepeaterStatusScreen> {
       _dupDirect = directDups;
       _dupFlood = floodDups;
     });
+    final connector = Provider.of<MeshCoreConnector>(context, listen: false);
+    connector.updateRepeaterBatterySnapshot(
+      widget.repeater.publicKeyHex,
+      batteryMv,
+      source: 'status_binary',
+    );
     _recordStatusResult(true);
   }
 
@@ -201,6 +209,18 @@ class _RepeaterStatusScreenState extends State<RepeaterStatusScreen> {
           _uptimeSecs = _asInt(data['uptime_secs']);
           _queueLen = _asInt(data['queue_len']);
           _debugFlags = _asInt(data['errors']);
+          final batteryMv = _batteryMv;
+          if (batteryMv != null) {
+            final connector = Provider.of<MeshCoreConnector>(
+              context,
+              listen: false,
+            );
+            connector.updateRepeaterBatterySnapshot(
+              widget.repeater.publicKeyHex,
+              batteryMv,
+              source: 'status_text',
+            );
+          }
         } else if (data.containsKey('noise_floor')) {
           _noiseFloor = _asInt(data['noise_floor']);
           _lastRssi = _asInt(data['last_rssi']);
@@ -590,18 +610,24 @@ class _RepeaterStatusScreenState extends State<RepeaterStatusScreen> {
   }
 
   String _batteryText() {
-    if (_batteryMv == null) return '—';
-    final percent = _batteryPercentFromMv(_batteryMv!);
-    final volts = (_batteryMv! / 1000.0).toStringAsFixed(2);
+    final connector = context.watch<MeshCoreConnector>();
+    final batteryMv =
+        connector.getRepeaterBatteryMillivolts(widget.repeater.publicKeyHex) ??
+        _batteryMv;
+    if (batteryMv == null) return '—';
+    final percent = estimateBatteryPercentFromMillivolts(
+      batteryMv,
+      _batteryChemistry(),
+    );
+    final volts = (batteryMv / 1000.0).toStringAsFixed(2);
     return '$percent% / ${volts}V';
   }
 
-  int _batteryPercentFromMv(int millivolts) {
-    const minMv = 3000;
-    const maxMv = 4200;
-    if (millivolts <= minMv) return 0;
-    if (millivolts >= maxMv) return 100;
-    return (((millivolts - minMv) * 100) / (maxMv - minMv)).round();
+  String _batteryChemistry() {
+    final settingsService = context.read<AppSettingsService>();
+    return settingsService.batteryChemistryForRepeater(
+      widget.repeater.publicKeyHex,
+    );
   }
 
   String _clockText() {

lib/screens/telemetry_screen.dart

@@ -12,6 +12,7 @@ import '../services/app_settings_service.dart';
 import '../services/repeater_command_service.dart';
 import '../widgets/path_management_dialog.dart';
 import '../helpers/cayenne_lpp.dart';
+import '../utils/battery_utils.dart';
 
 class TelemetryScreen extends StatefulWidget {
   final Contact repeater;
@@ -74,9 +75,19 @@ class _TelemetryScreenState extends State<TelemetryScreen> {
   }
 
   void _handleStatusResponse(Uint8List frame) {
+    final parsedTelemetry = CayenneLpp.parseByChannel(frame);
+    final batteryMv = _extractTelemetryBatteryMillivolts(parsedTelemetry);
+    if (batteryMv != null) {
+      final connector = Provider.of<MeshCoreConnector>(context, listen: false);
+      connector.updateRepeaterBatterySnapshot(
+        widget.repeater.publicKeyHex,
+        batteryMv,
+        source: 'telemetry',
+      );
+    }
     if (!mounted) return;
     setState(() {
-      _parsedTelemetry = CayenneLpp.parseByChannel(frame);
+      _parsedTelemetry = parsedTelemetry;
     });
 
     ScaffoldMessenger.of(context).showSnackBar(
@@ -411,20 +422,35 @@ class _TelemetryScreenState extends State<TelemetryScreen> {
     );
   }
 
-  String _batteryText(double? batteryMv) {
+  int? _extractTelemetryBatteryMillivolts(List<Map<String, dynamic>> entries) {
+    for (final entry in entries) {
+      if (entry['channel'] != 1) continue;
+      final values = entry['values'];
+      if (values is! Map<String, dynamic>) continue;
+      final voltage = values['voltage'];
+      if (voltage is num) return (voltage.toDouble() * 1000).round();
+    }
+    return null;
+  }
+
+  String _batteryText(double? telemetryVolts) {
     final l10n = context.l10n;
+    final connector = context.watch<MeshCoreConnector>();
+    final batteryMv =
+        connector.getRepeaterBatteryMillivolts(widget.repeater.publicKeyHex) ??
+        (telemetryVolts == null ? null : (telemetryVolts * 1000).round());
     if (batteryMv == null) return l10n.common_notAvailable;
-    final percent = _batteryPercentFromMv(batteryMv);
-    final volts = batteryMv.toStringAsFixed(2);
+    final chemistry = _batteryChemistry();
+    final percent = estimateBatteryPercentFromMillivolts(batteryMv, chemistry);
+    final volts = (batteryMv / 1000).toStringAsFixed(2);
     return l10n.telemetry_batteryValue(percent, volts);
   }
 
-  int _batteryPercentFromMv(double millivolts) {
-    const minMv = 2.800;
-    const maxMv = 4.200;
-    if (millivolts <= minMv) return 0;
-    if (millivolts >= maxMv) return 100;
-    return (((millivolts - minMv) * 100) / (maxMv - minMv)).round();
+  String _batteryChemistry() {
+    final settingsService = context.read<AppSettingsService>();
+    return settingsService.batteryChemistryForRepeater(
+      widget.repeater.publicKeyHex,
+    );
   }
 
   String _temperatureText(double? tempC, bool isImperialUnits) {