Fix review issues: dedicated l10n keys, remove unrelated CI/macOS changes, translate all locales

- Replace concatenated favorite toggle strings with dedicated listFilter_addToFavorites/removeFromFavorites keys
- Remove unrelated CI artifact upload step from build.yml
- Revert unrelated macOS GeneratedPluginRegistrant.swift change
- Add comment explaining groups hidden under favorites filter
- Translate new keys across all 14 locales
This commit is contained in:
zjs81
2026-02-24 20:07:15 -07:00
parent d5ac84430c
commit 50af2e0bc9
35 changed files with 266 additions and 101 deletions
+3 -2
View File
@@ -518,6 +518,7 @@ class _ContactsScreenState extends State<ContactsScreen>
})
.where((group) {
if (_typeFilter == ContactTypeFilter.all) return true;
// Groups don't have a favorite flag, so hide them under favorites filter
if (_typeFilter == ContactTypeFilter.favorites) return false;
for (final key in group.memberKeys) {
final contact = contactsByKey[key];
@@ -1099,8 +1100,8 @@ class _ContactsScreenState extends State<ContactsScreen>
),
title: Text(
isFavorite
? '${context.l10n.common_remove} ${context.l10n.listFilter_favorites}'
: '${context.l10n.common_add} ${context.l10n.listFilter_favorites}',
? context.l10n.listFilter_removeFromFavorites
: context.l10n.listFilter_addToFavorites,
),
onTap: () async {
Navigator.pop(sheetContext);