zjs81/meshcore-open
1
0
Fork 0
mirror of https://github.com/zjs81/meshcore-open.git synced 2026-07-10 10:37:06 +10:00
Code Issues Packages Projects Releases 2 Wiki Activity

fix: clamp cached unread totals to prevent negative badge counts

Browse Source 
Clamp both _cachedContactsUnreadTotal and _cachedChannelsUnreadTotal
to >= 0 after decrementing in markContactRead() and markChannelRead().
This prevents the totals from going negative if the cache drifts
out-of-sync, which could cause UI badges to display incorrect values.
This commit is contained in:
Serge Tarkovski
2026-02-18 20:15:29 +02:00
parent 87bcb6a6a3
commit afcc4db405
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/connector/meshcore_connector.dart
+2 -2
View File
@@ -418,7 +418,7 @@ class MeshCoreConnector extends ChangeNotifier {
final previousCount = _contactUnreadCount[contactKeyHex] ?? 0; final previousCount = _contactUnreadCount[contactKeyHex] ?? 0;
if (previousCount > 0) { if (previousCount > 0) {
_contactUnreadCount[contactKeyHex] = 0; _contactUnreadCount[contactKeyHex] = 0;
_cachedContactsUnreadTotal -= previousCount; _cachedContactsUnreadTotal = (_cachedContactsUnreadTotal - previousCount).clamp(0, _cachedContactsUnreadTotal);
_appDebugLogService?.info( _appDebugLogService?.info(
'Contact $contactKeyHex marked as read (was $previousCount unread)', 'Contact $contactKeyHex marked as read (was $previousCount unread)',
tag: 'Unread', tag: 'Unread',
@@ -435,7 +435,7 @@ class MeshCoreConnector extends ChangeNotifier {
if (channel != null && channel.unreadCount > 0) { if (channel != null && channel.unreadCount > 0) {
final previousCount = channel.unreadCount; final previousCount = channel.unreadCount;
channel.unreadCount = 0; channel.unreadCount = 0;
_cachedChannelsUnreadTotal -= previousCount; _cachedChannelsUnreadTotal = (_cachedChannelsUnreadTotal - previousCount).clamp(0, _cachedChannelsUnreadTotal);
_appDebugLogService?.info( _appDebugLogService?.info(
'Channel ${channel.name.isNotEmpty ? channel.name : channelIndex} marked as read (was $previousCount unread)', 'Channel ${channel.name.isNotEmpty ? channel.name : channelIndex} marked as read (was $previousCount unread)',
tag: 'Unread', tag: 'Unread',